Support the customization of the timeout parameter when using a blocking connection pool with a redis cluster#3724
Merged
petyaslavova merged 5 commits intoredis:masterfrom Aug 7, 2025
Conversation
…ig connection pool with a redis cluster
VincentHokie
changed the title
Collaborator
|
Hi @VincentHokie, thank you for your contribution! |
petyaslavova
added
maintenance
Collaborator
|
@VincentHokie can you please check the linter's failure? |
Contributor
Author
|
Done, @petyaslavova Let me know if anything else needs some attention |
Contributor
Author
|
Looking into the integration failure |
Collaborator
This is a known issue - flaky test. |
petyaslavova
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
The timeout parameter is not one of the allowed redis keys, despite it being used for BlockingConnectionPool uses.
Because we need to let the RedisCluster configure its connection pools, we need to pass in the parameters that eventually make it to the creation of the connection pool.
Whitelisting the timeout key does this, and a test has been added to validate this.